Allow configuring the update refresh window #812
Conversation
kdomanski
force-pushed
the
enable_auto_refresh
branch
from
bac4c73
to
956eb68
Compare
| @@ -126,6 +124,18 @@ def __init__(self, config: ConfigHelper) -> None: | |||
| # Auto Status Refresh | |||
| self.refresh_timer: Optional[FlexTimer] = None | |||
| if auto_refresh_enabled: | |||
| self.refresh_window = config.getintlist('refresh_window', [0, 5], | |||
There was a problem hiding this comment.
This should be moved outside of the condition. This way a user can toggle auto refresh on or off without removing "refresh_window" in the configuration.
In addition it guarantees that the self.refresh_window attribute is set. While it shouldn't be reachable when auto refresh is disabled, we avoid potential future bugs if there is a refactor that makes it reachable.
There was a problem hiding this comment.
Right. I forgot about the warning when an unused option is set. Fixed it now.
I could not decide whether the validation belongs up there with config.getintlist or right above the if auto_refresh_enabled: section. Let me know if you want it moved again.
|
Thanks. Overall it looks like a good addition, I just had one comment. |
kdomanski
force-pushed
the
enable_auto_refresh
branch
from
956eb68
to
f199d97
Compare
This enables customizing the time of day within which periodic refresh occurs. Previously docs said it happens between 12am-4am which is misleading, because the code effectively allowed refresh until 4:59:59 AM. The default window is now '0-5', which is practically the same as before. The comment about checking every 24h hours has been fixed as well. This hasn't been true since commit c4fa76f Signed-off-by: Kamil Domański <[email protected]>
kdomanski
force-pushed
the
enable_auto_refresh
branch
from
f199d97
to
e8e5803
Compare
|
Thanks. |
This enables customizing the time of day within which periodic refresh occurs.
Previously docs said it happens between 12am-4am which is misleading, because the code effectively allowed refresh until 4:59:59 AM. The default window is now '0-5', which is practically the same as before.
The comment about checking every 24h hours has been fixed as well. This hasn't been true since commit c4fa76f