Skip to content

Commit

Permalink
Fix schema editor (#404)
Browse files Browse the repository at this point in the history
Fix issue that prevent the json and avro schema editors from rendering
  • Loading branch information
mwylde authored Nov 11, 2023
1 parent f9615f8 commit bd9e895
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
2 changes: 2 additions & 0 deletions arroyo-console/src/routes/connections/DefineSchema.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ export const DefineSchema = ({
value: 'json',
el: (
<SchemaFormatEditor
key="jsoneditor"
connector={connector}
connectionProfiles={connectionProfiles!}
state={state}
Expand All @@ -260,6 +261,7 @@ export const DefineSchema = ({
value: 'avro',
el: (
<SchemaFormatEditor
key="avroeditor"
connector={connector}
connectionProfiles={connectionProfiles!}
state={state}
Expand Down
2 changes: 0 additions & 2 deletions arroyo-console/src/routes/connections/JsonForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -485,8 +485,6 @@ export function JsonForm({
});
}

console.log(errors);

return errors;
},
});
Expand Down
7 changes: 1 addition & 6 deletions arroyo-console/src/routes/connections/SchemaEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,7 @@ export function SchemaEditor({
}

useEffect(() => {
if (
monacoEl &&
!editor &&
!created.current &&
state.schema?.format?.json?.unstructured === false
) {
if (monacoEl && !editor && !created.current) {
let e = monaco.editor.create(monacoEl.current!, {
language: 'json',
theme: 'vs-dark',
Expand Down

0 comments on commit bd9e895

Please sign in to comment.