Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers and multiple subscription messages to Websocket source #379

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

jbeisen
Copy link
Collaborator

@jbeisen jbeisen commented Oct 20, 2023

Add headers and subscription_messages fields to the Websocket schema and
include them in the request. The console uses a new ArrayWidget
component to render this type of schema.


The subscription messages can be set in sql like this:

    "subscription_messages.0" = 'first message',
    "subscription_messages.1" = 'second message',

Or if there's only 1, the old way:

    subscription_message = 'only message',

Or through the form like this:

image

@jbeisen jbeisen force-pushed the websocket-headers-messages branch 5 times, most recently from 70bc95d to 9315921 Compare October 20, 2023 15:24
@@ -11,14 +11,25 @@
],
"format": "uri"
},
"subscription_message": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break existing websocket connections in your DB. Do you think it's worth keeping the old "subscription_message" around to provide backwards-compatibility?

@jbeisen jbeisen force-pushed the websocket-headers-messages branch from 9315921 to 0ec97f3 Compare October 20, 2023 18:25
Add headers and subscription_messages fields to the Websocket schema and
include them in the request. The console uses a new ArrayWidget
component to render this type of schema.
@jbeisen jbeisen force-pushed the websocket-headers-messages branch from 0ec97f3 to 9da62d6 Compare October 20, 2023 18:39
Copy link
Member

@mwylde mwylde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jbeisen jbeisen merged commit d0e6e63 into master Oct 20, 2023
8 checks passed
@jbeisen jbeisen deleted the websocket-headers-messages branch October 20, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants