Use udfs crate for compilation in addition to checking #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
force-pushed
the
unified_udf_compilation
branch
2 times, most recently
from
aa0270e to
371cc3a
Compare
mwylde
force-pushed
the
unified_udf_compilation
branch
from
371cc3a to
1ef26cb
Compare
jbeisen
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our UDF compilation model to use a separate crate, like we currently do for UDF checking. This reduces the number of places that new dependencies need to be added, and brings better parity between checking and actual compilation.
I've also removed extraneous dependencies from the UDF crate (arroyo-types in particular) which significantly speeds up checking.
I've verified that UDF compilation is working in these environments: