Make UDFs public when added to schema provider #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeisen
force-pushed
the
udfs-public
branch
3 times, most recently
from
ceeff3d to
54aa8d6
Compare
jbeisen
changed the title
jbeisen
force-pushed
the
udfs-public
branch
2 times, most recently
from
585b23a to
cc35c80
Compare
jbeisen
commented
Nov 14, 2023
Comment on lines
-483
to
-490
| _ => { | ||
| return Ok(Response::new(CheckUdfsResp { | ||
| errors: vec![ | ||
| "Only functions and use statements are allowed in UDFs".to_string() | ||
| ], | ||
| udf_name: None, | ||
| })) | ||
| } |
There was a problem hiding this comment.
As far as I know we don't actually need this check any more, so I didn't implement it in the ArroyoSchemaProvider.
Restore the previous logic of modifying the UDF syntax tree at the time we add it to the schema provider. Also use the schema provider in the check UDF flow. This removes some redundant logic from the controller and improves the error messages that now appear as UDF validation errors with their respective UDF rather than as just as query errors.
jacksonrnewhouse
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the previous logic of modifying the UDF syntax tree at the time
we add it to the schema provider.
Also use the schema provider in the check UDF flow. This removes some
redundant logic from the controller and improves the error messages that
now appear as UDF validation errors with their respective UDF rather
than as just as query errors.