arroyo-connectors: Test code-gen for JSON Schema and Avro. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksonrnewhouse
force-pushed
the
connectors/code_gen_schema_def_connectors
branch
from
27abc31 to
fb4692d
Compare
mwylde
reviewed
Nov 14, 2023
jacksonrnewhouse
force-pushed
the
connectors/code_gen_schema_def_connectors
branch
from
fb4692d to
e1172a8
Compare
mwylde
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates arroyo-sql-testing by registering two new kafka sources, one with a schema defined by JsonSchema, the other using an Avro definition. It is invoked from full_query_testing, and just confirms code is generated without issue. This required two changes:
crate::*. This only works if the definitions they need are at the top level of the crate. This is true for real pipelines, but not the test infrastructure.