arroyo-sql: make sure delta lake timestamps are microsecond grain. #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwylde
approved these changes
Nov 15, 2023
jacksonrnewhouse
force-pushed
the
delta/coerce_delta_writes_to_microseconds
branch
from
4f9757c to
ef5f201
Compare
zh4ngx
pushed a commit
to StrikeTeamOne/arroyo
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delta Lake requires timestamps to be microsecond grain, while we default to nanosecond. This patches the schema in arroyo-sql/src/tables, special casing for "delta". I'd like to move to connectors owning which types they support going forward.