Fix bug with "flex" element not settings their box.

ArthurSonzogni · Dec 25, 2024 · d907fe4 · d907fe4
1 parent d7ac14a
commit d907fe4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/ftxui/component/container.cpp b/src/ftxui/component/container.cpp
@@ -163,6 +163,7 @@ class VerticalContainer : public ContainerBase {
       return false;
     }
 
+    int old_selected = *selector_;
     if (event.mouse().button == Mouse::WheelUp) {
       MoveSelector(-1);
     }
@@ -171,7 +172,7 @@ class VerticalContainer : public ContainerBase {
     }
     *selector_ = std::max(0, std::min(int(children_.size()) - 1, *selector_));
 
-    return true;
+    return old_selected != *selector_;
   }
 
   Box box_;

diff --git a/src/ftxui/dom/flex.cpp b/src/ftxui/dom/flex.cpp
@@ -80,6 +80,7 @@ class Flex : public Node {
   }
 
   void SetBox(Box box) override {
+    Node::SetBox(box);
     if (children_.empty()) {
       return;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -80,6 +80,7 @@ class Flex : public Node { @@
       }
       void SetBox(Box box) override {
+        Node::SetBox(box);
         if (children_.empty()) {
           return;
         }
@@ Expand Down @@