Modularize global required method #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Namespace global required method * Update required call usage * Add additional required usage tests * Remove debugging code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #45 and builds off of mful's previous PR for this issue.
It should be noted that #45 specifically mentions a compatibility issue with FactoryBot, but the issue is much broader than that. This gem currently introduces a
requiredmethod globally in the projects that use it, which breaks any method namedrequiredin those projects.This solution:
requiredmethod to a newAsana::CompatibilityHelpermodule that can be used safely throughout this codebase without making it a global method in any project it's used in.My concerns with this solution:
I believe the method that I'm protecting here (
required) is only necessary to add support to a ruby version (2.0.0) that isn't actually supported by this gem. It likely could be removed, but it would require updates to the code generation codebase.