Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): separate toolbars from the content below with dividers #747

Merged
merged 2 commits into from
Nov 10, 2024
Merged

feat(ui): separate toolbars from the content below with dividers #747

merged 2 commits into from
Nov 10, 2024

Conversation

JunkFood02
Copy link
Collaborator

What:

  • Add two dividers between the toolbars and the content.
  • The top divider only appears when the article is being scrolled up.

Why:

  • To ensure there's suffient contrast between content and toolbars. When the tonal elevation of toolbars is set to 0 (default value), the toolbars actually uses the same container color as the content beneath.
  • Consider removing this preference and fixing the tonal elevation to 0
Screenshots

telegram-cloud-photo-size-5-6275907901017149382-y

telegram-cloud-photo-size-5-6275907901017149383-y

@Ashinch Ashinch added the enhancement New feature or request label Jun 19, 2024
@Ashinch Ashinch added this to the 0.11.0 milestone Jun 19, 2024
@JunkFood02 JunkFood02 merged commit 99e1d89 into main Nov 10, 2024
3 checks passed
@JunkFood02 JunkFood02 deleted the toolbar-divider branch November 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JunkFood02 @Ashinch