Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings.xml #887

Closed
wants to merge 1 commit into from
Closed

Conversation

nvllz
Copy link
Contributor

@nvllz nvllz commented Nov 17, 2024

Improved many strings, grammar errors, and tried to make the overall phrasing more consistent.

If you can, please check it for missing escape characters, not sure if everything is correct to merge.

@JunkFood02
Copy link
Collaborator

We're not an enterprise product so i think it's not that crucial to keep a consistent wording throughout the app. And many translations have already been submitted on hosted weblate. If we modify the source strings here, all the translations will be flagged as outdated, requiring our volunteers to retranslate them. To avoid this unnecessary work, I'd suggest that we only correct the strings that are genuinely confusing or unclear, leaving the others untouched

@nvllz
Copy link
Contributor Author

nvllz commented Nov 20, 2024

You spend so much time correcting tonal elevations and would keep bad phrasing? I really appreciate your work and wanted to help you improve the app. I guess the majority of users use English and the weblate thing will be fixed sooner or later. No "unnecessary work" if something can be improved, it's also about your honest work here.

@JunkFood02
Copy link
Collaborator

I couldn't care less about your strong desire to help us improve the app. Coding for the app, collecting user feedbacks, and reviewing pull requests all require time and effort. A large pull request that consists of many changes covering different issues is difficult to review and merge. If you still want to merge the changes in this PR, please break it down to smaller ones, each addressing a single issue like grammar, tone or mismatched descriptions.

@JunkFood02 JunkFood02 closed this Nov 20, 2024
@nvllz
Copy link
Contributor Author

nvllz commented Nov 20, 2024

If you still want to merge the changes in this PR, please break it down to smaller ones, each addressing a single issue like grammar, tone or mismatched descriptions.

No idea what's on your mind here, you can comment under lines you don't understand and I'll tell you why I decided to change it. I've already submitted a few strings.xml PRs, which got merged and @Ashinch never said weblate is a problem.

A large pull request that consists of many changes covering different issues is difficult to review and merge

It's just strings, no "other issues" here. Don't make me create 40 Pull Requests describing why "You can tap the account name on the feed page to toggle it" is wrong (since you're not really toggling, as in binary, but selecting another account from a list) just because I pointed out something in your PR. No shaming here, just correcting lines I thought needed improvement. Please consider it once again guys.

@JunkFood02
Copy link
Collaborator

make me create 40 Pull Requests describing why "You can tap the account name on the feed page to toggle it" is wrong

just do it, and you can include all your grammar fix in a single pr so it doesn't grow to 40

The current UI text does indeed need improvement. Some of these issues can be resolved by simply modifying the strings (such as the grammar issues you mentioned), while others require larger code-level changes to accommodate.

@nvllz
Copy link
Contributor Author

nvllz commented Nov 22, 2024

just do it, and you can include all your grammar fix in a single pr so it doesn't grow to 40

It's already here in this single PR, and you said I should break it into small PRs instead.. You just don't want to accept it because of my post under some of your PRs.

The current UI text does indeed need improvement. Some of these issues can be resolved by simply modifying the strings (such as the grammar issues you mentioned), while others require larger code-level changes to accommodate.

Huh... Someone found time to improve strings, and you said you didn't have time to review it, and then said it actually needs improvement. I'm lost.

@Ashinch what do you think of this PR? I assume Junkfood02 wants me to create like 40 different pull requests, each fixing a string with a broad description, as if it wasn't clear what I changed. This way of killing contributions is short-term thinking, and being offended by some comment under a random thing is childish. Please reconsider, and at least cherry pick improved strings instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants