fix: crash on assignment chain #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CountBleck
reviewed
Oct 16, 2023
| let ret = module.block(null, [ | ||
| this.makeCallDirect(setterInstance, [ | ||
| module.local_tee(tempThis.index, thisExpr, returnType.isManaged), | ||
| module.local_tee(tempThis.index, thisExpr, /* isManaged=*/false, thisType.toRef()), // thisType is managed but here it must be alive | ||
| valueExpr | ||
| ], valueExpression), | ||
| this.makeCallDirect(getterInstance, [ |
There was a problem hiding this comment.
Should we be calling the getter here? I tried this in the Node.js REPL:
> let x = { get y() { console.log("get"); return 123 }, set y(z) { console.log("set", z) } }
undefined
> let foo = x.y = 456
set 456
undefined
> foo
456It doesn't seem to call the getter, unless I'm missing something...
There was a problem hiding this comment.
I do realize you didn't write this, but I wanted to point out what I noticed.
There was a problem hiding this comment.
Maybe we can use temp variable to store it?
There was a problem hiding this comment.
Yeah, valueExpr should be tee'd to a temp local in the setter call, and the getter call should be replaced with a local.get to that local, if I'm correct about not calling that getter.
|
further issue see #2770 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating tee assignment, compiler use incorrect this type (type of return value).
It causes crash when return type is not
usize.Fixes: #2674