improve default argument const check #2768
Conversation
Using binaryen provided `ExpressionRunner` to run compilesToConst for more accurate evaluation results.
src/compiler.ts
Outdated
| let previousFlow = this.currentFlow; | ||
| this.currentFlow = instance.flow; | ||
| const expr = this.compileExpression( | ||
| initializer, | ||
| parameterTypes[i], | ||
| Constraints.ConvImplicit | ||
| ); | ||
| this.currentFlow = previousFlow; | ||
| const precomp = module.runExpression(expr, ExpressionRunnerFlags.Default); | ||
| if (precomp) { | ||
| operands.push(precomp); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Previously, since the expression was checked before compiling it, its side effects (like updating local states) would only be applied when indeed using the expression. With this change, its side-effects occur always due to compiling it unconditionally, even when the expression is not used, which is likely undesirable.
There was a problem hiding this comment.
With this change, its side-effects occur always due to compiling it unconditionally, even when the expression is not used, which is likely undesirable.
Which kind of side-effects do you mean?
If it is side effect for code, it can be detected by module.runExpression.
If it is side effect for compiler, here is in instance.flow, default argument definitely needs to be consider.
Using binaryen provided
ExpressionRunnerto run compilesToConst for more accurate evaluation results.