fix: return the assigned value in assignments #2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `makeAssignment`, `valueType` doesn't match witch valueExpr. But there are no actual influence for current generated wasm.
|
deps: #2772 |
HerrCai0907
force-pushed
the
2770-assignment-chain-cause-compatibility-issue
branch
from
dc9df96 to
f40e4a3
Compare
HerrCai0907
force-pushed
the
2770-assignment-chain-cause-compatibility-issue
branch
from
f40e4a3 to
a18920f
Compare
HerrCai0907
force-pushed
the
2770-assignment-chain-cause-compatibility-issue
branch
from
a18920f to
b755426
Compare
|
WDYT @CountBleck @dcodeIO @MaxGraey ? |
|
ping @CountBleck |
CountBleck
approved these changes
Nov 7, 2023
| return this.makeAssignment( | ||
| target, | ||
| this.convertExpression(valueExpr, valueType, targetType, false, valueExpression), |
There was a problem hiding this comment.
This code was better before, but this is okay.
CountBleck
changed the title
…in-cause-compatibility-issue
HerrCai0907
deleted the
2770-assignment-chain-cause-compatibility-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TS, assignment chain will assign result to each variable. But in AS, assignment chain will assign result to second variable and assign the value of second variable to the first variable.
It will cause incompatibility problem.
This patch assign result to a temporary local and assign it to each variable.
Fixes #2770.