Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create page for the "23:00 UTC artifact" #7

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Create page for the "23:00 UTC artifact" #7

merged 2 commits into from
Jan 25, 2023

Conversation

kandersolar
Copy link
Member

This addresses one of the items in #1:

The 23:00 UTC Tamb artifact in 5-minute data

The notebook is rather basic at the moment. Ideas for possible additions:

  • Show that some fields (e.g. irradiance) are not affected
  • Other data frequencies

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@AdamRJensen
Copy link
Member

My only issue going through this was the last plot. Upon initial inspection, the white space at the top merely looks like an artifact from setting the y-limit too high. Though I realize this is not the case, but the white is due to the diverging colormap and that there is no change in this region. I played around with a few other colormaps, but nothing I found was better (since it needs to be diverging to make sense).

Perhaps adding a light grey background to the plot helps enhance the white bar at the top of each subplots:

fig, axes = plt.subplots(2, 2, sharex=True, sharey=True, facecolor='lightgrey')

image

@kandersolar
Copy link
Member Author

Thanks for pointing out that issue. I thought about switching the plot to be in local time so that the white strip would be somewhere in the middle, but then went a different way altogether for summarizing the .diff() across a year of data (here it is in local standard time):

image

Separately, I've also extended the notebook along the lines at the top of this thread (irradiance is not affected by this artifact; 15- and 30-minute data have the same issue as 5-minute).

@kandersolar kandersolar mentioned this pull request Jan 24, 2023
23 tasks
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change in the plotting was a very nice improvement, well done :)

@kandersolar kandersolar merged commit f036dd0 into main Jan 25, 2023
@kandersolar kandersolar deleted the 2300 branch January 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants