feat: add maximum concurrent threads by using Parallel gem #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 404
💛 - Coveralls |
Travis tests have failedHey @RickCSong, Ruby: 2.3rakeRuby: 2.5rakeRuby: 2.6rakeRuby: 2.7rakeRuby: ruby-headrakeRuby: jruby-headrakeTravisBuddy Request Identifier: babbb6a0-5398-11ea-87d9-d7aacf6f1a64 |
Travis tests have failedHey @RickCSong, Ruby: 2.3rakeRuby: 2.5rakeRuby: 2.6rakeRuby: 2.7rakeRuby: ruby-headrakeRuby: jruby-headrakeTravisBuddy Request Identifier: a22ca5a0-539c-11ea-87d9-d7aacf6f1a64 |
Travis tests have failedHey @RickCSong, Ruby: 2.3rakeRuby: 2.5rakeRuby: 2.6rakeRuby: 2.7rakeRuby: ruby-headrakeRuby: jruby-headrakeTravisBuddy Request Identifier: 578aac00-53a0-11ea-87d9-d7aacf6f1a64 |
PikachuEXE
requested changes
Feb 20, 2020
There was a problem hiding this comment.
Got several changes
- Rename
concurrent_max_threads->concurrent_uploads_max_threads
Ensure this setting is for uploading files only - Use
Queue#closeadded since ruby 2.3 instead ofrescue ThreadError
https://hspazio.github.io/2017/ruby-threads-and-queues/
I modified the code from the article above to use Queue#close
require "thread"
work = Queue.new
(1..10).each do |i|
work.push(i)
end
work.close
num_consumers = 2
consumers = Array.new(num_consumers) do |n|
Thread.new do
while job = work.pop
puts "consumer #{n}: #{job}"
# simulate some work to do
sleep 2
end
end
end
consumers.map(&:join)
RickCSong
force-pushed
the
master
branch
2 times, most recently
from
e9f9616
to
0a32759
Compare
|
This is really great feedback @PikachuEXE ! I've updated the PR accordingly -- great callout on using I've also added tests since I believe we are generally happy with the direction of this change :) |
PikachuEXE
requested changes
Feb 21, 2020
lib/asset_sync/storage.rb
Outdated
| threads.add(Thread.new { upload_file f }) | ||
| workers = Array.new(num_threads) do | ||
| Thread.new do | ||
| begin |
There was a problem hiding this comment.
Why do you still need begin..end in Thread block?
|
@RickCSong |
Before, asset_sync would create a separate thread for every asset that was uplaoded. When there are a large number of assets being uploaded, this could lead to processes crashing due to too many threads being created. By limiting the number of threads, this speeds up performance while preventing crashes from resource starvation.
|
Sorry @PikachuEXE ! Done. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, asset_sync would create a separate thread for every asset that
was uplaoded. When there are a large number of assets being uploaded,
this could lead to processes crashing due to too many threads being
created.
By limiting the number of threads, this speeds up
performance while preventing crashes from resource starvation.
See: #395