Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the logic to validate the size comparison between the token's expiration time and refresh frequency so that it is executed only in init mode #181

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

y-myajima
Copy link
Contributor

@y-myajima y-myajima commented Jan 17, 2025

Description

We have modified the system so that when starting in init mode, it no longer performs a size comparison between the TokenRefresh and TokenExpiry settings at startup.

  • The size comparison between TokenRefresh and TokenExpiry is a logic used to prevent the token from expiring before the cache is updated when starting in refresh mode. Therefore, it is not necessary to execute the above comparison and validation logic in init mode.

Assignees

  • Assignees is set

Type of changes

  • Apply one or more labels of the following that fits:
    • bug: Bug fix
    • dependencies: Dependency upgrades
    • documentation: Documentation changes
    • enhancement: New Feature
    • good first issue: First contribution
    • logging: Log changes
    • refactor: Refactoring (no functional changes, no api changes)

Flags

- [ ] Breaks backward compatibility
- [ ] Requires a documentation update
- [ ] Has untestable code

Checklist

- [ ] Followed the guidelines in the CONTRIBUTING document
- [ ] Added prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]` in the PR title if necessary
- [ ] Tested and linted the code
- [ ] Commented the code
- [ ] Made corresponding changes to the documentation

Checklist for maintainer

- [ ] Use `Squash and merge`
- [ ] Double-confirm the merge message has prefix `[skip ci]`/`[ci skip]`/`[no ci]`/`[skip actions]`/`[actions skip]`
- [ ] Delete the branch after merge

@y-myajima y-myajima changed the title Modify the logic to validate the size comparison between the token's expiration time and refresh frequency so that it is executed only in init mode. Modify the logic to validate the size comparison between the token's expiration time and refresh frequency so that it is executed only in init mode Jan 20, 2025
@y-myajima y-myajima self-assigned this Jan 20, 2025
@y-myajima y-myajima added the bug Something isn't working label Jan 20, 2025
@y-myajima y-myajima requested a review from t4niwa January 20, 2025 08:14
Signed-off-by: myajima <[email protected]>
@y-myajima y-myajima merged commit 8ba0751 into main Jan 21, 2025
8 checks passed
@y-myajima y-myajima deleted the fix-token-refresh-validation-with-init-mode branch January 21, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants