Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make indexing minimal by default instead of disabled #1151

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Jul 17, 2024

Questions

Describe your pull request

  • Adds an 'indexConf.cmd' script that can toggle search indexing, add paths to it, and exclude paths from it
  • Doesn't disable search indexing by default but instead makes it minimal by excluding the 'Users' folder
    • This makes it so there's little to no CPU usage after initial indexing
    • This is in the form of a 'Minimal Search Indexing (default).cmd' script
  • Adds 'AtlasDesktop' to search indexing so that users can search for scripts in their start menu
  • Makes the 'Enable search indexing' script reset to the default search indexing settings, except AtlasDesktop

This is in response to the following features requiring indexing: web search on Windows 11, slideshow lock screen, and kDrive.

From my testing on Windows 11 with these scripts, everything seems to work, but I want to ensure it's all good, so testing on a VM (while checking the indexing settings to ensure it all works) would be appreciated.

@he3als he3als requested a review from Xyueta as a code owner July 17, 2024 18:30
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Jul 17, 2024
@he3als he3als changed the title feat: minimal indexing script, config index paths feat: make indexing minimal by default instead of disabled Jul 17, 2024
Copy link

@MrSuddenJoy MrSuddenJoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good to me. Well done 👍🏻

@he3als he3als merged commit e548a7d into main Jul 17, 2024
2 checks passed
@he3als he3als deleted the search-indexing-config branch July 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants