Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Install Software.ps1 #873

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Update Install Software.ps1 #873

merged 4 commits into from
Aug 1, 2023

Conversation

fakepepsilol
Copy link
Contributor

Adds Lightshot to the "Install Software.ps1" script.

@github-actions github-actions bot added playbook Playbook related issues/PRs actions GitHub Actions related issues or PRs labels Jul 31, 2023
@kekkodance
Copy link

sharex better

@thecatontheceiling
Copy link

agreed

@fakepepsilol
Copy link
Contributor Author

sharex better

it's not as lightweight as lightshot, if you want make a pull request to change it 🤷‍♂️

@JayXTQ
Copy link
Member

JayXTQ commented Jul 31, 2023

rather than arguing about what is better, why not add both or add what the people want. more people want sharex compared to the other software(s). Thanks for the PR

@JayXTQ
Copy link
Member

JayXTQ commented Jul 31, 2023

Also, you didn’t follow the template for pull requests as I can see, well, tbf I don’t know if it works anymore but yeah

@github-actions github-actions bot removed the actions GitHub Actions related issues or PRs label Jul 31, 2023
he3als
he3als previously approved these changes Jul 31, 2023
View reviewed changes
@fakepepsilol fakepepsilol dismissed he3als’s stale review July 31, 2023 17:35

The merge-base changed after approval.

@Atlas-OS Atlas-OS deleted a comment from JayXTQ Jul 31, 2023
@fakepepsilol
Copy link
Contributor Author

Also, you didn’t follow the template for pull requests as I can see, well, tbf I don’t know if it works anymore but yeah

My bad, I just felt that something so simple didn't need a lot of explanation that it works, will do that next time! As for the other file, I don't really know how it got there, I never really used Github before so this is kind of new to me.

he3als
he3als previously approved these changes Jul 31, 2023
View reviewed changes
@fakepepsilol fakepepsilol dismissed he3als’s stale review July 31, 2023 20:56

The merge-base changed after approval.

he3als
he3als previously approved these changes Aug 1, 2023
View reviewed changes
@fakepepsilol fakepepsilol dismissed he3als’s stale review August 1, 2023 12:02

The merge-base changed after approval.

@Xyueta Xyueta merged commit be5cb65 into Atlas-OS:dev Aug 1, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@he3als he3als he3als left review comments

Assignees
No one assigned
Labels
playbook Playbook related issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fakepepsilol @kekkodance @thecatontheceiling @JayXTQ @he3als @Xyueta @jacksyrm