Added minorSeventhSharpFive #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -333,6 +338,7 @@ extension ChordType: CustomStringConvertible { | |||
| case .halfDiminishedEleventh: return "Ø11" | |||
| case .majorSeventhFlatFive: return "^7b5" | |||
| case .majorSeventhSharpFive: return "^7#5" | |||
| case .minorSeventhSharpFive: return "m7#5" | |||
There was a problem hiding this comment.
Switch and Case Statement Alignment Violation: Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
| @@ -270,6 +274,7 @@ extension ChordType: CustomStringConvertible { | |||
| case .minorEleventh: return "m11" | |||
| case .halfDiminishedEleventh: return "ø11" | |||
| case .majorSeventhFlatFive: return "maj7♭5" | |||
| case .minorSeventhSharpFive: return "m7♯5" | |||
There was a problem hiding this comment.
Switch and Case Statement Alignment Violation: Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
| @@ -208,6 +211,7 @@ public enum ChordType: String, CaseIterable, Codable { | |||
| case .halfDiminishedEleventh: return [.m3, .d5, .m7, .m9, .P11] | |||
| case .majorSeventhFlatFive: return [.M3, .d5, .M7] | |||
| case .majorSeventhSharpFive: return [.M3, .A5, .M7] | |||
| case .minorSeventhSharpFive: return [.m3, .A5, .m7] | |||
There was a problem hiding this comment.
Switch and Case Statement Alignment Violation: Case statements should vertically align with their enclosing switch statement. (switch_case_alignment)
| case majorSeventhFlatFive | ||
|
|
||
| /// Major Seventh Sharp Five: Major Third, Augmented Fifth, Major Seventh | ||
| case majorSeventhSharpFive | ||
|
|
||
| /// Minor Seventh Flat Five: Minor Third, Diminished Fifth, Major Seventh | ||
| case minorSeventhSharpFive | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| let chord = Chord(.C, type: .minorSeventhSharpFive) | ||
| XCTAssertEqual(chord.description, "Cm7♯5") | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| let chord = Chord.getRankedChords(from: pitchSet) | ||
| XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♯5"]) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -46,6 +46,19 @@ class ChordTests: XCTestCase { | |||
| XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♭5"]) | |||
| } | |||
|
|
|||
| func testMajorSeventhSharpFive() { | |||
| let notes: [Int8] = [60, 64, 68, 71] | |||
| let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } ) | |||
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
|
Hi Matt, thanks for this, we're currently adding a lot more esoteric
chords, so this is perfect.
We are going to make some modifications to getRankedChords to be able to
identify better these esoteric chords, thanks for your patience and help!
…On Sat, Apr 13, 2024 at 06:46 hound[bot] ***@***.***> wrote:
***@***.***[bot]* commented on this pull request.
------------------------------
In Sources/Tonic/ChordType.swift
<#40 (comment)>:
> @@ -333,6 +338,7 @@ extension ChordType: CustomStringConvertible {
case .halfDiminishedEleventh: return "Ø11"
case .majorSeventhFlatFive: return "^7b5"
case .majorSeventhSharpFive: return "^7#5"
+ case .minorSeventhSharpFive: return "m7#5"
Switch and Case Statement Alignment Violation: Case statements should
vertically align with their enclosing switch statement.
(switch_case_alignment)
------------------------------
In Sources/Tonic/ChordType.swift
<#40 (comment)>:
> @@ -270,6 +274,7 @@ extension ChordType: CustomStringConvertible {
case .minorEleventh: return "m11"
case .halfDiminishedEleventh: return "ø11"
case .majorSeventhFlatFive: return "maj7♭5"
+ case .minorSeventhSharpFive: return "m7♯5"
Switch and Case Statement Alignment Violation: Case statements should
vertically align with their enclosing switch statement.
(switch_case_alignment)
------------------------------
In Sources/Tonic/ChordType.swift
<#40 (comment)>:
> @@ -208,6 +211,7 @@ public enum ChordType: String, CaseIterable, Codable {
case .halfDiminishedEleventh: return [.m3, .d5, .m7, .m9, .P11]
case .majorSeventhFlatFive: return [.M3, .d5, .M7]
case .majorSeventhSharpFive: return [.M3, .A5, .M7]
+ case .minorSeventhSharpFive: return [.m3, .A5, .m7]
Switch and Case Statement Alignment Violation: Case statements should
vertically align with their enclosing switch statement.
(switch_case_alignment)
------------------------------
In Sources/Tonic/ChordType.swift
<#40 (comment)>:
> case majorSeventhFlatFive
/// Major Seventh Sharp Five: Major Third, Augmented Fifth, Major Seventh
case majorSeventhSharpFive
+ /// Minor Seventh Flat Five: Minor Third, Diminished Fifth, Major Seventh
+ case minorSeventhSharpFive
+
Trailing Whitespace Violation: Lines should not have trailing whitespace.
(trailing_whitespace)
------------------------------
In Tests/TonicTests/ChordTests.swift
<#40 (comment)>:
> @@ -46,6 +46,19 @@ class ChordTests: XCTestCase {
XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♭5"])
}
+ func testMajorSeventhSharpFive() {
+ let notes: [Int8] = [60, 64, 68, 71]
+ let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } )
+ let chord = Chord.getRankedChords(from: pitchSet)
+ XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♯5"])
+ }
+
+ func testMinorSeventhSharpFive() {
+ let notes: [Int8] = [60, 63, 68, 71]
+ let chord = Chord(.C, type: .minorSeventhSharpFive)
+ XCTAssertEqual(chord.description, "Cm7♯5")
+ }
+
Trailing Whitespace Violation: Lines should not have trailing whitespace.
(trailing_whitespace)
------------------------------
In Tests/TonicTests/ChordTests.swift
<#40 (comment)>:
> @@ -46,6 +46,19 @@ class ChordTests: XCTestCase {
XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♭5"])
}
+ func testMajorSeventhSharpFive() {
+ let notes: [Int8] = [60, 64, 68, 71]
+ let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } )
+ let chord = Chord.getRankedChords(from: pitchSet)
+ XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♯5"])
+ }
+
Trailing Whitespace Violation: Lines should not have trailing whitespace.
(trailing_whitespace)
------------------------------
In Tests/TonicTests/ChordTests.swift
<#40 (comment)>:
> @@ -46,6 +46,19 @@ class ChordTests: XCTestCase {
XCTAssertEqual(chord.map { $0.description }, ["Cmaj7♭5"])
}
+ func testMajorSeventhSharpFive() {
+ let notes: [Int8] = [60, 64, 68, 71]
+ let pitchSet = PitchSet(pitches: notes.map { Pitch($0) } )
Closing Brace Spacing Violation: Closing brace with closing parenthesis
should not have any whitespaces in the middle. (closing_brace)
—
Reply to this email directly, view it on GitHub
<#40 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKRXV5FYJAYKNSBFPYGCKTY5EZKJAVCNFSM6AAAAABGFPON6WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOJZGI3DMMJQG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
I would accept the typos in another PR, but I think this chords addition is not nearly as complete as Max's latest PR, so I will close this unmerged. I hope you understand, soon you can try the new chords set and see if that works for you (or try Max's fork). |
|
Sounds good - thanks @aure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a minorSeventhSharpFive chord.
There may be something funny going on with Chord.getRankedChords. I tried using that method but it didn't find the new chord. However, using Chord(.C, type: .minorSeventhSharpFive) works in the test.
*Fixed a couple of typos in comments too