[Feature/958] Update Existing Correction Form with Current System #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do?
Updated the existing data correction form to work with the new, current correction system that has been in development for a couple months. The existing form has become the new book correction form while any other correction forms will be made on needs and requirements in future tickets.
How is it Done?
First, updated the HTML form with new fields and cleaned up existing attributes and values. Then, implemented client-side validation and logic to make sure the correction was valid. Added a sanitizer for the description field as HTML tags are currently used for formatting.
Then, ran several local tests with the existing tickets, squashing bugs and forgotten edge cases along the way. The API has a couple of bugs within this system and a hotfix was already pushed to development.
Related Tickets and Issues
Internal#958