[Feature/844] Added Markdown Support to Pages #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do?
Adds markdown support to pages where users are able to input values (ie: profile descriptions). In addition, various other places like book descriptions now accept markdown formatting which help reduce the usage of inline HTML and risk of HTML injection.
How is it Done?
Added a new dependency which adds the markdown support to Angular. From there, div tags were modified to use the new markdown tags with proper configurations.
Related Tickets and Issues
Internal#844
Other Information:
These commits were accidentally added into an existing in-progress ticket, Internal#601. Upon review, these changes can go through. A separate, clean-up PR for the series page changes will be made at a later date.