-
Notifications
You must be signed in to change notification settings - Fork 518
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactored various procs used by VV: Header generation, dropdown menu generation, moved various things around, some defines. Fixed VV to be able to edit associative lists. Fixed VV to be able to make a list ex nihilo on a var. Removed various dropdown menus that didn't exist anymore and were doing nothing. Fixed add verb option to not wipe the already existing verbs of the mob. Fixed a runtime error on some lists view building that were not handled correctly. Fixed an issue with build mode not having the correct permissions for devs. Fixed an issue with editing a list referenced by a key in another list via the edit referenced object option. Added DF_VAR_EDITED flag.
- Loading branch information
1 parent
426c961
commit 7cc7778
Showing
11 changed files
with
212 additions
and
112 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
//#define IS_VALID_ASSOC_KEY(V) (istext(V) || ispath(V) || isdatum(V) || islist(V)) | ||
#define IS_VALID_ASSOC_KEY(V) (!isnum(V)) //hhmmm.. | ||
|
||
// vv_do_basic() keys | ||
#define VV_HK_BASIC_EDIT "datumedit" | ||
#define VV_HK_BASIC_CHANGE "datumchange" | ||
//This differs from TG | ||
#define VV_HK_BASIC_MASSEDIT "datummass" | ||
|
||
// /datum | ||
#define VV_HK_CALLPROC "proc_call" | ||
#define VV_HK_MARK "mark" | ||
|
||
//Helpers for vv_get_dropdown() - yes this is different from the tg one, cope | ||
#define VV_DROPDOWN_OPTION(href_key, name) . += "<option value='?_src_=vars;[href_key]=[REF(src)]'>[name]</option>" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
/datum/proc/can_vv_get(var_name) | ||
return TRUE | ||
|
||
/// Called when a var is edited with the new value to change to | ||
/datum/proc/vv_edit_var(var_name, var_value) | ||
if(var_name == NAMEOF(src, vars)) | ||
return FALSE | ||
if(!can_vv_get(var_name)) //This if block does not exist in tgstation code | ||
return FALSE | ||
vars[var_name] = var_value | ||
datum_flags |= DF_VAR_EDITED | ||
return TRUE | ||
|
||
/** | ||
* Gets all the dropdown options in the vv menu. | ||
* When overriding, make sure to call . = ..() first and appent to the result, that way parent items are always at the top and child items are further down. | ||
* Add seperators by doing VV_DROPDOWN_OPTION("", "---") | ||
*/ | ||
/datum/proc/vv_get_dropdown() | ||
SHOULD_CALL_PARENT(TRUE) | ||
|
||
. = list() | ||
VV_DROPDOWN_OPTION("", "---") | ||
VV_DROPDOWN_OPTION(VV_HK_CALLPROC, "Call Proc") | ||
VV_DROPDOWN_OPTION(VV_HK_MARK, "Mark Object") | ||
|
||
/datum/proc/vv_get_header() | ||
. = list() | ||
if(("name" in vars) && !isatom(src)) | ||
. += "<b>[vars["name"]]</b><br>" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.