-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exosuit Nuclear Power Cores #18268
Exosuit Nuclear Power Cores #18268
Conversation
Geevies
commented
Jan 20, 2024
- Added power cores, a type of large battery cell that get used by exosuits. The nuclear and phoron variants are self-charging.
- Combat mechs now start with nuclear power cores, allowing them to sustain themselves indefinitely, so long as they stay out of the action for a bit.
- Removed basic power cells from the mechfab, replaced with the mech powercores.
- Mech cell statuses now instantly update as soon as the cell charges or discharges.
- Added a stack of 10 uranium to the machinist's workshop, which can print two nuclear power cores.
!review |
if(body.cell) | ||
RegisterSignal(body.cell, COMSIG_CELL_CHARGE, PROC_REF(handle_cell_charge)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unregister it on destroy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as i'm aware, signals are already unregistered when any datum gets destroyed, so it shouldn't be necessary, unless i missed something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be right
Can they be recharged? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nline # Conflicts: # aurorastation.dme # code/game/objects/items/devices/suit_cooling.dm # code/game/objects/items/weapons/stunbaton.dm # code/modules/heavy_vehicle/mech_interaction.dm # maps/sccv_horizon/sccv_horizon-2_deck_2.dmm
Yes, these power cores can be put into a standard recharger, though the charge rate will be painfully slow due to the core's capacity relative to the recharger's output. I think it's a fair trade-off that, if you go through the effort of removing the core, that you can charge it (slowly). The power cores can also be charged by the stationary docking chargers, which is also fair, since you need to either go to the place where they're installed, or specifically construct one in the area you'll be working. |
!review |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nline # Conflicts: # code/game/objects/items/weapons/power_cells.dm # icons/obj/machinery/cell_charger.dmi
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…nline # Conflicts: # code/modules/heavy_vehicle/mech_interaction.dm