Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exosuit Nuclear Power Cores #18268

Merged
merged 11 commits into from
Jun 9, 2024

Conversation

Geevies
Copy link
Contributor

@Geevies Geevies commented Jan 20, 2024

  • Added power cores, a type of large battery cell that get used by exosuits. The nuclear and phoron variants are self-charging.
  • Combat mechs now start with nuclear power cores, allowing them to sustain themselves indefinitely, so long as they stay out of the action for a bit.
  • Removed basic power cells from the mechfab, replaced with the mech powercores.
  • Mech cell statuses now instantly update as soon as the cell charges or discharges.
  • Added a stack of 10 uranium to the machinist's workshop, which can print two nuclear power cores.

@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Jan 20, 2024
@github-actions github-actions bot added the 🗺️ Mapping - Horizon The PR touches the Horizon map files. label Jan 20, 2024
@Geevies
Copy link
Contributor Author

Geevies commented Jan 20, 2024

!review

code/game/objects/items/devices/suit_cooling.dm Outdated Show resolved Hide resolved
code/game/objects/items/weapons/stunbaton.dm Outdated Show resolved Hide resolved
Comment on lines +209 to +210
if(body.cell)
RegisterSignal(body.cell, COMSIG_CELL_CHARGE, PROC_REF(handle_cell_charge))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unregister it on destroy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as i'm aware, signals are already unregistered when any datum gets destroyed, so it shouldn't be necessary, unless i missed something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be right

code/game/objects/items/weapons/power_cells.dm Outdated Show resolved Hide resolved
code/modules/heavy_vehicle/interface/_interface.dm Outdated Show resolved Hide resolved
code/modules/heavy_vehicle/interface/_interface.dm Outdated Show resolved Hide resolved
@NonQueueingMatt NonQueueingMatt added the Changes Required The PR requires changes before it can be approved and/or merged. label Jan 30, 2024
@DreamySkrell
Copy link
Contributor

Can they be recharged?

Copy link

github-actions bot commented Feb 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…nline

# Conflicts:
#	aurorastation.dme
#	code/game/objects/items/devices/suit_cooling.dm
#	code/game/objects/items/weapons/stunbaton.dm
#	code/modules/heavy_vehicle/mech_interaction.dm
#	maps/sccv_horizon/sccv_horizon-2_deck_2.dmm
@Geevies
Copy link
Contributor Author

Geevies commented Apr 20, 2024

Can they be recharged?

Yes, these power cores can be put into a standard recharger, though the charge rate will be painfully slow due to the core's capacity relative to the recharger's output. I think it's a fair trade-off that, if you go through the effort of removing the core, that you can charge it (slowly).

The power cores can also be charged by the stationary docking chargers, which is also fair, since you need to either go to the place where they're installed, or specifically construct one in the area you'll be working.

@Geevies
Copy link
Contributor Author

Geevies commented Apr 20, 2024

!review

@BotBOREALIS BotBOREALIS removed the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 20, 2024
Copy link

github-actions bot commented May 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…nline

# Conflicts:
#	code/game/objects/items/weapons/power_cells.dm
#	icons/obj/machinery/cell_charger.dmi
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

…nline

# Conflicts:
#	code/modules/heavy_vehicle/mech_interaction.dm
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Jun 9, 2024
Merged via the queue into Aurorastation:master with commit 2bf39c7 Jun 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Horizon The PR touches the Horizon map files. Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants