Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instruments to the loadout and also ports some TG in-hand sprites for them. #18389

Merged

Conversation

4000daniel1
Copy link
Contributor

Hopefully restricting them to off-duties and passengers will prevent them from being all too overused (might'd be a bit weird to bring your old guitar with you to work every single day).

@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Feb 9, 2024
@4000daniel1
Copy link
Contributor Author

!review

@alsoandanswer
Copy link
Contributor

Not fond of the idea of crew getting instruments.

@alsoandanswer alsoandanswer added the ⛔ Maintainer Discussion The PR will be discussed by the maintainers. label Feb 10, 2024
@Arrow768
Copy link
Member

It is already possible to order these items via OPs.
I dont see too much point in adding it to the loadout.

@4000daniel1
Copy link
Contributor Author

4000daniel1 commented Feb 11, 2024

It is already possible to order these items via OPs. I dont see too much point in adding it to the loadout.

Characters who ICly know how to play instruments, would probably already own an instrument. Therefore having to order one from ops feels a bit odd IMO. Especially considering it'd be gone next round and then they'd have to order it again.

For example, let's say a group of characters wanted to form a little band and want to have band practices while they're off duty, I'd say them bringing their own personal instruments with them from the residential deck makes a whole lot more sense than them having to buy new ones from ops every time they want to practice.

@sadkermit
Copy link
Contributor

i like this. i have a character who found a guitar in maintenance which they took to their room - it doesnt make sense to keep ordering one from Ops each time i want to do some RP with a guitar in-hand :S

there is an instruments sfx mute button too, for all the people who dont like hearing shitty MIDIfied songs.

@OolongCow
Copy link
Contributor

In theory I support the idea since it allows crew to roleplay a bit more, but in reality I dread the inevitable hub players running down the halls playing Despacito.

If they were non-functional it wouldn't even be a question. As-is I can't really say whether I'm for or against it. I don't think without changes that it's the right call.

@4000daniel1
Copy link
Contributor Author

Went ahead and made a feedback thread for this: https://forums.aurorastation.org/topic/19807-adding-instruments-to-loadout-yay-or-nay/

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Arrow768 Arrow768 removed the ⛔ Maintainer Discussion The PR will be discussed by the maintainers. label May 5, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue May 12, 2024
Merged via the queue into Aurorastation:master with commit 8c566ac May 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants