Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planes & Layers part 2: Plane Masters #18749

Merged
merged 12 commits into from
Apr 13, 2024

Conversation

Generalcamo
Copy link
Contributor

@Generalcamo Generalcamo commented Mar 25, 2024

Part 2 of the PR series to bring /tg/'s and bay's plane masters to Aurora, the lack of which is blocking several features we want.

This ports over the easier to understand Bay version of plane masters, which is detailed in the relevant readme file in the code. Example effect code for a warp effect is also in, which has been implemented for gravity catapults.

Relies on #18741

@BotBOREALIS BotBOREALIS added Mapping: Aurora A legacy mapping label for the bot. Mapping: Runtime A legacy mapping label for the bot. labels Mar 25, 2024
@github-actions github-actions bot added 🗺️ Mapping - Aurora The PR touches the Aurora map files. 🗺️ Mapping - Runtime The PR touches the Runtime map files. 🗺️ Mapping - Horizon The PR touches the Horizon map files. 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. 🗺️ Mapping - Event The PR touches event map files. 🗺️ Mapping - Dungeon The PR touches dungeon map files. 🗺️ Mapping - Random Ruins The PR touches random ruins map files. 🗺️ Mapping - Templates The PR touches template map files. labels Mar 25, 2024
@Generalcamo Generalcamo force-pushed the plane_masters branch 6 times, most recently from 2b9aa3d to 7f5c96d Compare March 25, 2024 20:00
@Generalcamo Generalcamo marked this pull request as ready for review March 25, 2024 20:02
@Generalcamo
Copy link
Contributor Author

!review

code/__DEFINES/__initialization.dm Outdated Show resolved Hide resolved
code/__DEFINES/_macros.dm Outdated Show resolved Hide resolved
@Generalcamo Generalcamo force-pushed the plane_masters branch 2 times, most recently from 25915be to cf910b0 Compare March 27, 2024 00:30
Copy link

github-actions bot commented Apr 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed 🗺️ Mapping - Random Ruins The PR touches random ruins map files. 🗺️ Mapping - Templates The PR touches template map files. labels Apr 1, 2024
@Ben10083 Ben10083 mentioned this pull request Apr 3, 2024
1 task
@FluffyGhoster
Copy link
Contributor

It looks like this/the previous PR is/are so far causing these issues I noticed:

  • Space is white, lacking the icon
  • Character preview is black, without the character nor background
  • Windows are rendered above shutters
  • There's a newscaster in the middle of the central hall, D2 for some reason
  • There's also a part of it in D3, or at least it's visible through the floor
  • Air alarm in D3 too, on the other side
  • Zmimic does not seem to shade the lower layers properly
  • People seem to be masked below floorlights
  • Skrells seems to go below the railings in D2, for some reason; it doesn't seem to do that with humans - Same with the bluespace beacon outside security in D2
  • Sensors and starmap seems to have issues too, though I was only told so, so I'm not sure if it actually is true

@RustingWithYou
Copy link
Contributor

Sensors and starmap seems to have issues too, though I was only told so, so I'm not sure if it actually is true

Can confirm - overmap effects are layered below the overmap space turfs for some reason, meaning that navigation is effectively impossible.

This has also caused some bugs with mapping - pipes are now layered under all turfs in StrongDMM, making atmos mapping very difficult

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 3, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Apr 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Apr 13, 2024
Merged via the queue into Aurorastation:master with commit c1d2415 Apr 13, 2024
24 checks passed
@Generalcamo Generalcamo deleted the plane_masters branch April 18, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Mapping: Aurora A legacy mapping label for the bot. Mapping: Runtime A legacy mapping label for the bot. Review Required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants