Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unathi Trawler #18828

Merged
merged 50 commits into from
May 12, 2024
Merged

Unathi Trawler #18828

merged 50 commits into from
May 12, 2024

Conversation

EJDenton
Copy link
Contributor

@EJDenton EJDenton commented Apr 1, 2024

Adds a new civilian unathi ship, intended to fly into shoals to harvest carp.

image

@EJDenton
Copy link
Contributor Author

EJDenton commented Apr 1, 2024

!wip

@BotBOREALIS BotBOREALIS added the WIP The PR is a work in progress and should not be reviewed yet. label Apr 1, 2024
@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 1, 2024
@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 28, 2024

image
scrubbers can connect to scrubber pipes AND/OR normal pipes (the ones in the center of the turf)
so this scrubber may connect to either/both the black propellant line and/or red scrubber line

in any case it is bad practice to have pipes and pipe connectors/vents/etc on a single turf
(unless if the area is super tight, but this is not)

image
would be better like this

@DreamySkrell
Copy link
Contributor

image
replace this air tank with air canister on a connector, cause there is no way to refill air of this tank rn

@DreamySkrell
Copy link
Contributor

image
do not change layer of pipes/pumps/etc

image
generally just don't change the layer variable of anything

@DreamySkrell
Copy link
Contributor

image

don't have to change the large tank/chamber now, but in the future use /obj/effect/map_effect/marker/large_tank, see civ yacht or scc scout for example

@DreamySkrell
Copy link
Contributor

image
use /obj/effect/map_effect/window_spawner/full/shuttle/mercenary for all the windows so they get window frames matching the walls

@DreamySkrell
Copy link
Contributor

update your branch from master as it is outdated by over two weeks

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops wrong button meant to request changes not approve

@DreamySkrell DreamySkrell added the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 28, 2024
@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label May 1, 2024
@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label May 4, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue May 12, 2024
Merged via the queue into Aurorastation:master with commit cf72230 May 12, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants