Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator augment #18905

Merged

Conversation

SidVeld
Copy link
Contributor

@SidVeld SidVeld commented Apr 9, 2024

Adds an augmented translator to the game, with which the user can understand all human languages. I did not add a translator from xeno languages, as it would have been very strong, given the difficulty of translation and the peculiarities of their languages.

I have decomposed the original augment file to improve readability and code handling. Hopefully this won't cause trouble in the future. (Sorry, but an 800+ line file is a very large file.)

@DreamySkrell
Copy link
Contributor

not sure if adding it to the loadout is wanted
but the code refactor and splitting up files is nice

and if not wanted in the loadout, the augment could still be added, just not for crew to use

@SidVeld
Copy link
Contributor Author

SidVeld commented Apr 9, 2024

not sure if adding it to the loadout is wanted but the code refactor and splitting up files is nice

and if not wanted in the loadout, the augment could still be added, just not for crew to use

In fact it's a good question. While writing the code, I was inspired by Deus Ex and Cyberpunk where similar augments exist and then I thought "Hey, why not let 2D spacemen install a translator in their head?".

Maybe we should raise the price of it or limit access to humans only (Right now I think everyone except Vaurca can get it). It seems like it would just be a nice bonus for humans, when it would be a serious advantage for xenos.

All in all, some interesting concepts along the lines of a character who only knows Tau Basic and uses a translator to understand the speech of the rest of us. However, I'm too dreamy and don't envision the possible impact on the game in the round.

We'll see what the review says. If they ask me to change something, I'll change it.

@SidVeld
Copy link
Contributor Author

SidVeld commented Apr 9, 2024

!review

@Sniblet
Copy link
Contributor

Sniblet commented Apr 9, 2024

Elyrans forgotten as always
Everybody's opposed to opening up languages at all for reasons that I can't explain. One-way translators would make a world of sense given the uses for it and the fact that the technology literally, mechanically already exists (integrated electronics) and also mostly exists in real life, and I'm personally in a constant hostile relationship with the language limits on IPCs especially, but I don't expect this to go through.
The fact that it's so easy to get, and so justifiable in a setting like Horizon, means probably everyone without a religious exemption is going to want to have one. And then what's the point of having separate languages? Fluff? Fluff in my flipping roleplaying game?

But anyway, Elyran Standard is a human language. It's reasonable for a translation augment to not be packaged with Elyran, but then you just can't say that it has all human languages, because it doesn't.

@SidVeld
Copy link
Contributor Author

SidVeld commented Apr 9, 2024

OH, CRAP, I FORGOT ABOUT ELYRANS!

AALIYAH_WROTE_JAY_AN_APOLOGY_LETTER📃__MARK_WANT_DESIREE_AND_HANNAH!😱_4-32_screenshot_(1)-1515311997.jpg

Copy link
Contributor

@Geevies Geevies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for splitting the files, that file was getting a little big

i agree that this aug is cool, and even if we don't keep it in the loadout, having it be an antag or ghost role item would be cool

code/modules/mob/say.dm Outdated Show resolved Hide resolved
code/modules/mob/say.dm Outdated Show resolved Hide resolved
code/modules/organs/subtypes/augment/augments/timepeace.dm Outdated Show resolved Hide resolved
html/changelogs/sidveld-augment-translator.yml Outdated Show resolved Hide resolved
@SidVeld
Copy link
Contributor Author

SidVeld commented Apr 13, 2024

@Geevies Thanks for the review. Your comments helped make some good edits.

@SidVeld SidVeld requested a review from Geevies April 13, 2024 17:03
Copy link
Contributor

@Geevies Geevies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@NonQueueingMatt NonQueueingMatt added the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 15, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@NonQueueingMatt NonQueueingMatt removed the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 17, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Apr 17, 2024
Merged via the queue into Aurorastation:master with commit 63b5617 Apr 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants