Origin Trait Changes + Vaurca Language Traits #18912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RustingWithYou
requested review from
Arrow768,
NonQueueingMatt and
DreamySkrell
as code owners
|
!review |
github-actions
bot
added
the
🗺️ Mapping - Away Ship/Away Site
Geevies
approved these changes
Apr 12, 2024
NonQueueingMatt
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin traits, as well as species natural armor, will correctly remove themselves when culture/origin/species is changed.
Vaurca primary language processors (K'lax Sinta'Unathi and C'thur Nral'malic) are now culture traits rather than loadout items. This means that they can be added/removed from ghostroles automatically without having to copypaste the same code 200 times.
Secondary language processors (Sinta'Azaziba, Freespeak, Tradeband) have stayed as loadout items as some of them do not have distinct cultures or origins they can be added to.