Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSMD Updates #18916

Merged
merged 24 commits into from
Apr 15, 2024
Merged

SSMD Updates #18916

merged 24 commits into from
Apr 15, 2024

Conversation

lavillastrangiato
Copy link
Contributor

@lavillastrangiato lavillastrangiato commented Apr 10, 2024 •
edited
Loading

GitHub, you are stupid.

  • Updates airlocks on the SSMD Corvette.
  • Updates some access stuff on the SSMD Corvette.
  • Replaces some fake objects and 3/4th'd stuff in the SSMD Corvette.
  • Adds CO2 tanks!
  • Renames the SSMD Corvette to the Sol Reconaissance Corvette.

From @TheDanseMacabre: Edits the text on the ghost roles to match lore.
Also fixes #15452.

@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 10, 2024
@lavillastrangiato
Copy link
Contributor Author

!review

@DreamySkrell
Copy link
Contributor

image
transit area is wrong (shuttle added there to show it can't fit inside the X teleporters)

image
should be more like this

@DreamySkrell
Copy link
Contributor

image
entry points are wrong on the shuttle
like here is /aft subtype entry point renamed to fore, cockpit

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 13, 2024 •
edited
Loading

image
image
do not overlap scrubbers/vents with pipes, except if super super tight (but here it's not)
these scrubbers may also connect to to the propellant pipes

@DreamySkrell DreamySkrell added the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 13, 2024
@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 13, 2024
@NonQueueingMatt NonQueueingMatt added this pull request to the merge queue Apr 15, 2024
Merged via the queue into Aurorastation:master with commit 40cbb37 Apr 15, 2024
24 checks passed
@lavillastrangiato lavillastrangiato deleted the badlandsextravaganza branch April 17, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NonQueueingMatt NonQueueingMatt NonQueueingMatt approved these changes

@DreamySkrell DreamySkrell DreamySkrell approved these changes

Assignees
No one assigned
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSMD Ship Issues
4 participants
@lavillastrangiato @DreamySkrell @NonQueueingMatt @BotBOREALIS