Function overloads condensation #18939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FluffyGhoster
requested review from
Arrow768,
JohnWildkins and
NonQueueingMatt
as code owners
FluffyGhoster
added
Refactor
⚠ High Risk
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
🗺️ Mapping - Away Ship/Away Site
This reverts commit 51f39eb.
|
!review |
1 task
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Acetrea
reviewed
Apr 15, 2024
code/modules/reagents/Chemistry-Reagents/Chemistry-Reagents-Dispenser.dm
Show resolved
Hide resolved
NonQueueingMatt
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unified most of the procs into one definition, so there are no duplicate around the codebase.
Marked some of the above as overridable if a good enough case can be made for them (eg. external dependency or unlikely to be used).