Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensor relay refit #19021

Merged
merged 20 commits into from
May 5, 2024
Merged

Sensor relay refit #19021

merged 20 commits into from
May 5, 2024

Conversation

nauticall
Copy link
Contributor

@nauticall nauticall commented Apr 24, 2024

Overhauls the sensor relay away site to be up to modern standards. It's now more practical, more decrepit, and has more facilities for things while retaining the old loot and goodies it had before.

The place starts depowered, save for the airlocks, which are powered by default to allow entry without having to bust down a window/wall/inflatable and vent the place.

In addition this PR adds a special sprite for the sensor array the relay uses, and tweaks its stats:

  • Now has a maximum range of 24.
  • Has a stable range of 10.
  • Cannot deep scan at all.
  • Overheats very quickly at high ranges.
  • Detects passing ships slower than a standard relay.

The above should make it more worthwhile to capture and use, as when datalinked it provides visibility of a large portion of the sector.

image

image
image

Before powering

image

After powering

Click to expand

image
image
image
image
image
image
image

@nauticall nauticall added the WIP The PR is a work in progress and should not be reviewed yet. label Apr 24, 2024
@BotBOREALIS BotBOREALIS added Changelog Required Sprites Adds new or changes existing sprites. labels Apr 24, 2024
@github-actions github-actions bot added the 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. label Apr 24, 2024
@nauticall
Copy link
Contributor Author

!review

@BotBOREALIS BotBOREALIS added Review Required and removed WIP The PR is a work in progress and should not be reviewed yet. labels Apr 25, 2024
@nauticall nauticall marked this pull request as ready for review April 25, 2024 15:50
@nauticall
Copy link
Contributor Author

nauticall commented Apr 25, 2024

todo: remove old relay dmm and populate pr info

done

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 26, 2024

is this ready for review

title says it's WIP, it still needs changelog, there is a "todo: " comment here

@nauticall nauticall changed the title Sensor relay refit (WIP) Sensor relay refit Apr 27, 2024
@nauticall
Copy link
Contributor Author

is this ready for review

it's ready now

@@ -640,3 +640,16 @@
/obj/item/bluespace_crystal,
/obj/item/stack/cable_coil = 30
)

/obj/machinery/shipsensors/strong/venator/relay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be /obj/machinery/shipsensors/strong/relay
venator sensors are specific to horizon
and this subtype overrides all the vars anyways

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also have component_types and its own circuit board

Copy link
Contributor

@DreamySkrell DreamySkrell Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo it should also not scan further out than Horizon's sensors
horizon's sensors are supposed to be the best of the best, most high tech, etc
meanwhile some tiny old sensors on a tiny old station are better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, the Horizon is supposed to have the most power sensors around. It was one of the selling points for the initial lore arc when it launched.

@DreamySkrell
Copy link
Contributor

image
image
do these work in game and allow other shuttles to arrive at these, and depart properly?
I did not test them locally but I would expect them to use plating for base_turf

@DreamySkrell
Copy link
Contributor

DreamySkrell commented Apr 29, 2024

image
this can spawn in any sector, NKA comics are not fitting on it, especially since it's supposed to be a pre-war thing

Copy link
Contributor

@DreamySkrell DreamySkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@DreamySkrell DreamySkrell added the Changes Required The PR requires changes before it can be approved and/or merged. label Apr 29, 2024
@DreamySkrell DreamySkrell removed the Changes Required The PR requires changes before it can be approved and/or merged. label May 4, 2024
@Alberyk Alberyk added this pull request to the merge queue May 5, 2024
Merged via the queue into Aurorastation:master with commit 6c079c4 May 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants