-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAPI - byondapi test #19100
Merged
Merged
BAPI - byondapi test #19100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!review |
!build_bapi |
1 similar comment
!build_bapi |
…rora.3 into 2024-05-05--bapi
!build_bapi |
NonQueueingMatt
approved these changes
May 6, 2024
// Default automatic .dll/.so detection. | ||
// Look for it in the build location first, then in `.`, then in standard places. | ||
|
||
/* This comment bypasses grep checks */ /var/__bapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why aren't we using GLOB here?
Arrow768
approved these changes
May 7, 2024
BotBOREALIS
added
the
Waiting Period
The PR has the required number of reviews, but is still in the waiting period
label
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Review Required
Test Merge Candidate
The PR is eligible for test merging.
Tools
Waiting Period
The PR has the required number of reviews, but is still in the waiting period
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what and why:
byondapi stuff
byondapi is cool
implementation is very heavily inspired by ParadiseSS13/Paradise#25328
this PR adds a very minimal but usable rust project to the repo
this was test-merged to see if it actually works in game on the live server
but as it is now the PR does not add any byondapi calls to dm code