Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BAPI - byondapi test #19100

Merged
merged 20 commits into from
May 7, 2024
Merged

Conversation

DreamySkrell
Copy link
Contributor

@DreamySkrell DreamySkrell commented May 5, 2024

what and why:

byondapi stuff
byondapi is cool
implementation is very heavily inspired by ParadiseSS13/Paradise#25328
this PR adds a very minimal but usable rust project to the repo
this was test-merged to see if it actually works in game on the live server
but as it is now the PR does not add any byondapi calls to dm code

DreamySkrell added 3 commits May 5, 2024 12:44
DreamySkrell added 4 commits May 5, 2024 15:18
@DreamySkrell DreamySkrell added the Test Merge Candidate The PR is eligible for test merging. label May 5, 2024
@DreamySkrell
Copy link
Contributor Author

!review

DreamySkrell added 3 commits May 6, 2024 10:11
@DreamySkrell
Copy link
Contributor Author

!build_bapi

1 similar comment
@DreamySkrell
Copy link
Contributor Author

!build_bapi

@DreamySkrell
Copy link
Contributor Author

!build_bapi

// Default automatic .dll/.so detection.
// Look for it in the build location first, then in `.`, then in standard places.

/* This comment bypasses grep checks */ /var/__bapi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why aren't we using GLOB here?

@Arrow768 Arrow768 added this pull request to the merge queue May 7, 2024
@BotBOREALIS BotBOREALIS added the Waiting Period The PR has the required number of reviews, but is still in the waiting period label May 7, 2024
Merged via the queue into Aurorastation:master with commit f8d8724 May 7, 2024
26 checks passed
@DreamySkrell DreamySkrell deleted the 2024-05-05--bapi branch May 14, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Required Test Merge Candidate The PR is eligible for test merging. Tools Waiting Period The PR has the required number of reviews, but is still in the waiting period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants