Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add otpauth migration support #560

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Add otpauth migration support #560

merged 2 commits into from
Dec 17, 2020

Conversation

Sneezry
Copy link
Member

@Sneezry Sneezry commented Dec 7, 2020

Copy link
Member

@mymindstorm mymindstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I haven't had the time to test this just yet. I will open an issue later if I find anything.

Copy link
Member

@mymindstorm mymindstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly, although it was not easy to get the QR onto my computer. It's a bit odd that only the import page allows this type of import, can we make this work via normal QR scanning?

@Sneezry
Copy link
Member Author

Sneezry commented Dec 17, 2020

Works perfectly, although it was not easy to get the QR onto my computer. It's a bit odd that only the import page allows this type of import, can we make this work via normal QR scanning?

The QR code should be captured from mobile App, and transferred to computer. So I think it should be a local image file. Because we have already removed file://* permission, we are not able to scan local images via normal QR scanning.

@mymindstorm
Copy link
Member

Works perfectly, although it was not easy to get the QR onto my computer. It's a bit odd that only the import page allows this type of import, can we make this work via normal QR scanning?

So I think it should be a local image file. Because we have already removed file://* permission, we are not able to scan local images via normal QR scanning.

There are some situations where this could happen, e.g. the screenshot is uploaded to Google drive and scanned in from the preview.

@Sneezry
Copy link
Member Author

Sneezry commented Dec 17, 2020

Works perfectly, although it was not easy to get the QR onto my computer. It's a bit odd that only the import page allows this type of import, can we make this work via normal QR scanning?

So I think it should be a local image file. Because we have already removed file://* permission, we are not able to scan local images via normal QR scanning.

There are some situations where this could happen, e.g. the screenshot is uploaded to Google drive and scanned in from the preview.

Make sense. I will update the PR to add this feature.

@Sneezry
Copy link
Member Author

Sneezry commented Dec 17, 2020

I will make another PR for scanning migration QR code. Closing this one.

@Sneezry Sneezry merged commit 8065d5f into dev Dec 17, 2020
@Sneezry Sneezry deleted the otpauth-migration branch December 17, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants