Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy/cli): add reset-consume-offset command #556

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

TheR1sing3un
Copy link
Contributor

  1. add reset-consume-offset command

Copy link

github-actions bot commented Nov 2, 2023

Qodana for JVM

8 new problems were found

Inspection name Severity Problems
AutoCloseable used without 'try'-with-resources 🔶 Warning 2
Field can be local 🔶 Warning 2
@NotNull/@Nullable problems 🔶 Warning 2
Duplicated code fragment ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #556 (2c10276) into main (efec93e) will decrease coverage by 0.36%.
Report is 2 commits behind head on main.
The diff coverage is 10.71%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #556      +/-   ##
============================================
- Coverage     57.96%   57.60%   -0.36%     
- Complexity     1948     1952       +4     
============================================
  Files           207      209       +2     
  Lines         13259    13359     +100     
  Branches       1210     1216       +6     
============================================
+ Hits           7685     7695      +10     
- Misses         4959     5049      +90     
  Partials        615      615              
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.85% <ø> (ø)
RocketMQ Controller 49.39% <ø> (ø)
RocketMQ Proxy 40.24% <10.71%> (-2.47%) ⬇️
RocketMQ Store 77.79% <ø> (+0.31%) ⬆️
RocketMQ Stream 60.41% <ø> (ø)
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
...cketmq/controller/client/GrpcControllerClient.java 58.67% <ø> (ø)
...ketmq/controller/server/ControllerServiceImpl.java 57.56% <ø> (ø)
.../controller/server/store/DefaultMetadataStore.java 48.18% <ø> (ø)
...tmq/controller/server/store/impl/GroupManager.java 57.83% <ø> (ø)
...tmq/controller/server/store/impl/TopicManager.java 57.54% <ø> (ø)
...q/controller/server/tasks/ReclaimS3ObjectTask.java 33.33% <ø> (ø)
...ocketmq/controller/server/tasks/RecycleS3Task.java 3.17% <ø> (ø)
.../controller/server/tasks/TerminationStageTask.java 0.00% <ø> (ø)
...tmq/metadata/service/DefaultS3MetadataService.java 69.32% <ø> (ø)
...c/main/java/com/automq/rocketmq/metadata/Loop.java 69.44% <ø> (ø)
... and 7 more

... and 2 files with indirect coverage changes

@TheR1sing3un TheR1sing3un enabled auto-merge (rebase) November 3, 2023 07:04
@daniel-y
Copy link
Contributor

daniel-y commented Nov 7, 2023

这个解决下冲突,我们早点合进去吧

1. support reset consume offset processor

Signed-off-by: TheR1sing3un <[email protected]>
1. resolve conflicts after rebasing

Signed-off-by: TheR1sing3un <[email protected]>
1. support reset consume offset cli tool

Signed-off-by: TheR1sing3un <[email protected]>
1. delete `S3MetadataManager` in controller

Signed-off-by: TheR1sing3un <[email protected]>
1. resolve conflicts after rebasing

Signed-off-by: TheR1sing3un <[email protected]>
@TheR1sing3un TheR1sing3un merged commit e808cc7 into main Nov 14, 2023
7 of 9 checks passed
@TheR1sing3un TheR1sing3un deleted the feat_cmd_reset_offset branch November 14, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants