Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): use dedicated executor for token bucket in DataBlockReader #635

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 15, 2023

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #635 (1176ad2) into main (782ec0d) will decrease coverage by 0.02%.
The diff coverage is 68.75%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #635      +/-   ##
============================================
- Coverage     58.31%   58.29%   -0.02%     
+ Complexity     1993     1989       -4     
============================================
  Files           210      210              
  Lines         13378    13383       +5     
  Branches       1215     1216       +1     
============================================
+ Hits           7801     7802       +1     
- Misses         4956     4958       +2     
- Partials        621      623       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.85% <ø> (ø)
RocketMQ Controller 53.52% <ø> (ø)
RocketMQ Proxy 40.12% <ø> (-0.13%) ⬇️
RocketMQ Store 77.43% <ø> (ø)
RocketMQ Stream 60.27% <68.75%> (-0.01%) ⬇️
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
...om/automq/stream/s3/compact/CompactionManager.java 58.61% <80.00%> (+0.46%) ⬆️
...mq/stream/s3/compact/operator/DataBlockReader.java 58.10% <50.00%> (-1.08%) ⬇️

... and 3 files with indirect coverage changes

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@superhx superhx merged commit cad6505 into main Nov 15, 2023
8 of 9 checks passed
@superhx superhx deleted the multi_pool branch November 15, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants