Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): evict log cache by capacity #637

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 15, 2023

No description provided.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #637 (5feb4ac) into main (cad6505) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 45.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #637      +/-   ##
============================================
- Coverage     58.32%   58.29%   -0.03%     
- Complexity     1991     2020      +29     
============================================
  Files           210      213       +3     
  Lines         13383    13424      +41     
  Branches       1216     1220       +4     
============================================
+ Hits           7806     7826      +20     
- Misses         4955     4973      +18     
- Partials        622      625       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.85% <ø> (ø)
RocketMQ Controller 53.71% <ø> (+0.18%) ⬆️
RocketMQ Proxy 40.24% <ø> (+0.12%) ⬆️
RocketMQ Store 77.48% <ø> (-0.25%) ⬇️
RocketMQ Stream 60.12% <45.45%> (-0.12%) ⬇️
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
.../src/main/java/com/automq/stream/s3/S3Storage.java 60.63% <100.00%> (ø)
...main/java/com/automq/stream/s3/cache/LogCache.java 70.06% <66.66%> (+0.20%) ⬆️
...m/src/main/java/com/automq/stream/s3/S3Stream.java 31.42% <0.00%> (-0.74%) ⬇️

... and 11 files with indirect coverage changes

Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@SCNieh SCNieh merged commit 9d1ef3b into main Nov 15, 2023
@SCNieh SCNieh deleted the fix_log_cache_evict branch November 15, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants