Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream/wal): try to flush at a fixed rate #645

Merged
merged 10 commits into from
Nov 16, 2023

Conversation

Chillax-0v0
Copy link
Contributor

fix #608
fix #629

@Chillax-0v0 Chillax-0v0 requested a review from superhx November 15, 2023 12:27
@Chillax-0v0 Chillax-0v0 self-assigned this Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #645 (fbe2ce1) into main (f143c28) will increase coverage by 0.49%.
Report is 2 commits behind head on main.
The diff coverage is 70.22%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #645      +/-   ##
============================================
+ Coverage     57.92%   58.42%   +0.49%     
- Complexity     2021     2061      +40     
============================================
  Files           216      218       +2     
  Lines         13499    13603     +104     
  Branches       1221     1247      +26     
============================================
+ Hits           7819     7947     +128     
+ Misses         5054     5031      -23     
+ Partials        626      625       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.85% <ø> (ø)
RocketMQ Controller 55.78% <ø> (+2.25%) ⬆️
RocketMQ Proxy 40.12% <ø> (ø)
RocketMQ Store 77.25% <ø> (+0.04%) ⬆️
RocketMQ Stream 59.54% <70.22%> (+0.12%) ⬆️
RocketMQ Metadata 35.67% <ø> (ø)
Files Coverage Δ
.../main/java/com/automq/stream/s3/wal/WALHeader.java 97.40% <100.00%> (ø)
...n/java/com/automq/stream/s3/wal/WriteAheadLog.java 100.00% <ø> (ø)
...java/com/automq/stream/s3/wal/util/WALChannel.java 81.81% <100.00%> (+6.81%) ⬆️
.../com/automq/stream/s3/wal/util/WALFileChannel.java 75.86% <100.00%> (+0.42%) ⬆️
...main/java/com/automq/stream/s3/wal/BlockBatch.java 95.45% <95.45%> (ø)
...tomq/stream/s3/wal/util/WALBlockDeviceChannel.java 0.00% <0.00%> (ø)
...eam/src/main/java/com/automq/stream/s3/Config.java 31.61% <40.00%> (-0.18%) ⬇️
...java/com/automq/stream/s3/wal/BlockWALService.java 72.99% <50.00%> (-0.58%) ⬇️
...com/automq/stream/s3/wal/SlidingWindowService.java 91.41% <89.47%> (+1.46%) ⬆️
...com/automq/stream/s3/wal/benchmark/WriteBench.java 10.05% <26.47%> (+2.45%) ⬆️

... and 27 files with indirect coverage changes

Copy link

github-actions bot commented Nov 15, 2023

Qodana for JVM

2 new problems were found

Inspection name Severity Problems
Call to 'printStackTrace()' 🔶 Warning 1
Method can be extracted ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Signed-off-by: Ning Yu <[email protected]>
@superhx superhx merged commit 1fc40ae into main Nov 16, 2023
9 checks passed
@superhx superhx deleted the feat-wal-flush-at-fixed-rate branch November 16, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants