Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lookup DB if leader address is not yet cached #659

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

@lizhanhui lizhanhui requested a review from wangxye November 17, 2023 05:16
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #659 (51677e1) into main (3b0b582) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 62.50%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #659   +/-   ##
=========================================
  Coverage     59.57%   59.58%           
- Complexity     2152     2161    +9     
=========================================
  Files           223      224    +1     
  Lines         13803    13835   +32     
  Branches       1279     1285    +6     
=========================================
+ Hits           8223     8243   +20     
- Misses         4925     4931    +6     
- Partials        655      661    +6     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 58.17% <62.50%> (+0.07%) ⬆️
RocketMQ Proxy 42.75% <ø> (ø)
RocketMQ Store 77.71% <ø> (ø)
RocketMQ Stream 60.76% <ø> (-0.03%) ⬇️
RocketMQ Metadata 35.29% <ø> (ø)
Files Coverage Δ
.../controller/server/store/DefaultMetadataStore.java 67.28% <62.50%> (+0.34%) ⬆️

... and 8 files with indirect coverage changes

@lizhanhui lizhanhui enabled auto-merge (squash) November 17, 2023 05:22
Copy link

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@lizhanhui lizhanhui merged commit 322d795 into main Nov 17, 2023
@lizhanhui lizhanhui deleted the lookup_leader_address branch November 17, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants