Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kafka_issues475): do not log when fast fail #751

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 28, 2023

@superhx superhx requested a review from Chillax-0v0 November 28, 2023 06:50
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #751 (4bffdcb) into main (f5224c1) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #751      +/-   ##
============================================
- Coverage     57.36%   57.32%   -0.04%     
+ Complexity     1223     1221       -2     
============================================
  Files           131      131              
  Lines          8047     8047              
  Branches        736      736              
============================================
- Hits           4616     4613       -3     
- Misses         3034     3035       +1     
- Partials        397      399       +2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.60% <ø> (ø)
RocketMQ Proxy 42.62% <ø> (ø)
RocketMQ Store 76.96% <ø> (-0.15%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx superhx merged commit 701892f into main Nov 28, 2023
@superhx superhx deleted the fix_kissues475 branch November 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastReadFailFastException when try to consume from the beginning
2 participants