Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): add more metrics #845

Merged
merged 3 commits into from
Dec 20, 2023
Merged

feat(s3stream): add more metrics #845

merged 3 commits into from
Dec 20, 2023

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Dec 19, 2023

  1. add metrics for usage of deltaWAL, deltaWAL cache, blockCache
  2. add metrics for inflight r/w quota for S3Operator
  3. add size bucket for r/w object operation
  4. explicitly set bucket boundaries for histogram of latency

@SCNieh SCNieh requested a review from superhx December 19, 2023 10:08
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0cb47d3) 55.33% compared to head (68f8e0d) 55.35%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #845      +/-   ##
============================================
+ Coverage     55.33%   55.35%   +0.02%     
- Complexity     1247     1249       +2     
============================================
  Files           132      132              
  Lines          8574     8574              
  Branches        788      788              
============================================
+ Hits           4744     4746       +2     
  Misses         3414     3414              
+ Partials        416      414       -2     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 74.62% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx superhx enabled auto-merge (squash) December 20, 2023 03:00
@superhx superhx merged commit 35cbeaa into main Dec 20, 2023
12 of 13 checks passed
@superhx superhx deleted the s3_metrics branch December 20, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants