fix(s3stream/wal): fix checks before scaleOutWindow
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #873 +/- ##
============================================
- Coverage 55.00% 54.97% -0.04%
+ Complexity 1246 1243 -3
============================================
Files 133 133
Lines 8535 8535
Branches 789 789
============================================
- Hits 4695 4692 -3
Misses 3426 3426
- Partials 414 417 +3
|
Chillax-0v0
force-pushed
the
fix-wal-scale-out-window
branch
from
d8785cd to
dd1008d
Compare
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Signed-off-by: Ning Yu <[email protected]>
Chillax-0v0
force-pushed
the
fix-wal-scale-out-window
branch
from
3a9ef7c to
efb9950
Compare
ShadowySpirits
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #872