Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(s3stream): use read lock rather than write lock in append #886

Merged
merged 5 commits into from
Jan 8, 2024
Merged

perf(s3stream): use read lock rather than write lock in append #886

merged 5 commits into from
Jan 8, 2024

Conversation

Chillax-0v0
Copy link
Contributor

@Chillax-0v0 Chillax-0v0 commented Jan 5, 2024 •
edited
Loading

@Chillax-0v0 Chillax-0v0 added the enhancement New feature or request label Jan 5, 2024
@Chillax-0v0 Chillax-0v0 requested a review from superhx January 5, 2024 11:55
@Chillax-0v0 Chillax-0v0 self-assigned this Jan 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dab15a) 55.01% compared to head (5e1d4ae) 55.03%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #886      +/-   ##
============================================
+ Coverage     55.01%   55.03%   +0.02%     
  Complexity     1247     1247              
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4695     4697       +2     
+ Misses         3425     3424       -1     
+ Partials        414      413       -1
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.58% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.74% <ø> (+0.09%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@Chillax-0v0 Chillax-0v0 requested a review from superhx January 6, 2024 06:19
@Chillax-0v0 Chillax-0v0 marked this pull request as draft January 6, 2024 06:46
@Chillax-0v0 Chillax-0v0 marked this pull request as ready for review January 6, 2024 07:33
@superhx superhx merged commit 8aa4cf0 into main Jan 8, 2024
8 checks passed
@superhx superhx deleted the perf-s3stream-use-read-lock-rather-than branch January 8, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superhx superhx superhx approved these changes

Assignees

@Chillax-0v0 Chillax-0v0

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chillax-0v0 @superhx