Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3stream): fix delayed release for StreamDataBlock #945

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Feb 26, 2024

No description provided.

@SCNieh SCNieh requested review from superhx and daniel-y February 26, 2024 08:11
Signed-off-by: Shichao Nie <[email protected]>
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.94%. Comparing base (23bf90c) to head (5cf26ef).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #945      +/-   ##
============================================
+ Coverage     55.92%   55.94%   +0.01%     
  Complexity     1267     1267              
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4773     4774       +1     
  Misses         3327     3327              
+ Partials        434      433       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (ø)
RocketMQ Store 73.65% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 1 file with indirect coverage changes

@superhx superhx merged commit 684e272 into main Feb 26, 2024
8 checks passed
@superhx superhx deleted the compaction branch February 26, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants