refactor: always try the first buffer in cache

Signed-off-by: Ning Yu <[email protected]>
AutoMQ · Aug 14, 2024 · cb67f05 · cb67f05
1 parent 7d1180d
commit cb67f05
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java b/clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java
@@ -156,7 +156,7 @@ public ByteBuffer get(int minCapacity) {
         @Override
         public void release(ByteBuffer buffer) {
             buffer.clear();
-            buffers.addLast(buffer);
+            buffers.addFirst(buffer);
         }
 
         @Override

diff --git a/clients/src/test/java/org/apache/kafka/common/utils/GrowableMultiBufferSupplierTest.java b/clients/src/test/java/org/apache/kafka/common/utils/GrowableMultiBufferSupplierTest.java
@@ -62,8 +62,8 @@ void testGetAndReleaseMultipleBuffers() {
         bufferSupplier.release(buffer1);
         bufferSupplier.release(buffer2);
 
-        ByteBuffer result1 = bufferSupplier.get(5);
-        ByteBuffer result2 = bufferSupplier.get(10);
+        ByteBuffer result2 = bufferSupplier.get(5);
+        ByteBuffer result1 = bufferSupplier.get(10);
         assertSame(buffer1, result1);
         assertSame(buffer2, result2);
         assertEquals(0, result1.position());