feat(eventLoop): the visibility of the shutdown flag for the event loop and optimizations for graceful shutdown #1796
Conversation
CLFutureX
requested review from
superhx,
SCNieh,
ShadowySpirits and
Chillax-0v0
as code owners
CLFutureX
changed the title
| @@ -79,6 +89,9 @@ public void execute(Runnable task) { | |||
|
|
|||
| public CompletableFuture<Void> shutdownGracefully() { | |||
| shutdown = true; | |||
| if (!shutdownCf.isDone()) { | |||
There was a problem hiding this comment.
To ensure concurrent safety, the operations of modifying shutdown and tasks need to be safeguarded by a lock. Similarly, other methods that use these two variables need to be modified.
There was a problem hiding this comment.
To ensure concurrent safety, the operations of modifying
shutdownandtasksneed to be safeguarded by a lock. Similarly, other methods that use these two variables need to be modified.
Yes, perhaps we can modify the shutdown from a constant to an AtomicBoolean, utilizing CAS (Compare-And-Swap) to ensure concurrent safety.
There was a problem hiding this comment.
To ensure concurrent safety, the operations of modifying
shutdownandtasksneed to be safeguarded by a lock. Similarly, other methods that use these two variables need to be modified.
now, the tasks variable has also been modified.
|
@superhx Perhaps it should only adjust the visibility of the shutdown variable, without introducing a wakeup mechanism, because the worst-case scenario would only involve a wait of 100ms, which is generally acceptable for a graceful shutdown, What do you think? |
| import org.slf4j.Logger; | ||
|
|
||
| public class EventLoop extends Thread implements Executor { | ||
| private final Logger logger; | ||
| private BlockingQueue<Runnable> tasks; | ||
| private boolean shutdown = false; | ||
| private volatile boolean shutdown; |
There was a problem hiding this comment.
Did not see when shutdown = true was set
If it's not completed, I think it's ok to add the shutdown awake. |
|
@superhx hey, please take a look |
The visibility of the shutdown flag for the event loop and optimizations for graceful shutdown