Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Revert "perf: use netty buffer to pool memory (#1788)" #1797

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ShadowySpirits
Copy link
Contributor

There is an issue related to #1788 that needs temporary reversion.

[2024-08-14 16:36:07,774] ERROR Encountered fatal fault: Unexpected error in raft IO thread (org.apache.kafka.server.fault.ProcessTerminatingFaultHandler)
java.lang.IllegalArgumentException: Got an unexpected empty key in the record
	at org.apache.kafka.raft.internals.RecordsIterator.decodeControlRecord(RecordsIterator.java:351)
	at org.apache.kafka.raft.internals.RecordsIterator.readRecord(RecordsIterator.java:316)
	at org.apache.kafka.raft.internals.RecordsIterator.readBatch(RecordsIterator.java:217)
	at org.apache.kafka.raft.internals.RecordsIterator.nextBatch(RecordsIterator.java:194)
	at org.apache.kafka.raft.internals.RecordsIterator.hasNext(RecordsIterator.java:89)
	at org.apache.kafka.raft.internals.KRaftControlRecordStateMachine.maybeLoadLog(KRaftControlRecordStateMachine.java:200)
	at org.apache.kafka.raft.internals.KRaftControlRecordStateMachine.updateState(KRaftControlRecordStateMachine.java:98)
	at org.apache.kafka.raft.KafkaRaftClient.appendAsLeader(KafkaRaftClient.java:1282)
	at org.apache.kafka.raft.KafkaRaftClient.appendBatch(KafkaRaftClient.java:1995)
	at org.apache.kafka.raft.KafkaRaftClient.maybeAppendBatches(KafkaRaftClient.java:2030)
	at org.apache.kafka.raft.KafkaRaftClient.pollLeader(KafkaRaftClient.java:2077)
	at org.apache.kafka.raft.KafkaRaftClient.pollCurrentState(KafkaRaftClient.java:2247)
	at org.apache.kafka.raft.KafkaRaftClient.poll(KafkaRaftClient.java:2388)
	at org.apache.kafka.raft.KafkaRaftClientDriver.doWork(KafkaRaftClientDriver.java:62)
	at org.apache.kafka.server.util.ShutdownableThread.run(ShutdownableThread.java:135)

@ShadowySpirits ShadowySpirits merged commit dd6b5c1 into main Aug 14, 2024
4 checks passed
@ShadowySpirits ShadowySpirits deleted the revert_optimize_perf branch August 14, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants