Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LogicBuilder.Expressions.Utils #187

Merged
merged 3 commits into from
Aug 18, 2023

Conversation

matthewtquinn1
Copy link
Contributor

Resolves #186

@matthewtquinn1
Copy link
Contributor Author

@BlaiseD OK to merge? 😄

@BlaiseD
Copy link
Member

BlaiseD commented Aug 17, 2023

@matthewtquinn1 - we should be all set once you sign the CLA.

@matthewtquinn1
Copy link
Contributor Author

@BlaiseD Thank you.

had a look at the CLA - it says the author must sign it; would that be the author of the repo? Or this PR?

@BlaiseD
Copy link
Member

BlaiseD commented Aug 18, 2023

@BlaiseD Thank you.

had a look at the CLA - it says the author must sign it; would that be the author of the repo? Or this PR?

Must be the PR. The CLA check only come up on your first contribution.

@matthewtquinn1
Copy link
Contributor Author

matthewtquinn1 commented Aug 18, 2023

@BlaiseD Sorry I've never seen this before. Is there a guide for how to sign it?

@matthewtquinn1
Copy link
Contributor Author

@microsoft-github-policy-service agree

@BlaiseD
Copy link
Member

BlaiseD commented Aug 18, 2023

This might help. Here's another resource.

@matthewtquinn1
Copy link
Contributor Author

matthewtquinn1 commented Aug 18, 2023

@BlaiseD That first link no longer works, they say that it is an old and unused method of doing it now ;(

The second link, I see it suggests how to accept it here but I followed that step and it still hasn't passed [https://cla2.dotnetfoundation.org/](https://github.com/microsoft/contributorlicenseagreement#accepting)

@BlaiseD
Copy link
Member

BlaiseD commented Aug 18, 2023

Here's an example from another PR.

@matthewtquinn1
Copy link
Contributor Author

@matthewtquinn1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="Full Staq Ltd"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

@dotnet-policy-service agree company="Full Staq Ltd"

@matthewtquinn1
Copy link
Contributor Author

@dotnet-policy-service agree company="Full Staq Ltd"

@matthewtquinn1
Copy link
Contributor Author

@BlaiseD Got it! Ready to merge :)

@BlaiseD BlaiseD merged commit 8e522ea into AutoMapper:master Aug 18, 2023
3 checks passed
@BlaiseD
Copy link
Member

BlaiseD commented Aug 19, 2023

@jbogard - is it possible part of the CLA workflow is missing for AutoMapper.Extensions.OData? I suspect the prompt/instructions were not clear/visible for @matthewtquinn1 compared with e.g. this PR from the Expression Mapping repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependency LogicBuilder.Expressions.Utils
2 participants