fixed race conditioning in indices_boundary_masker #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c indices at corners and edges.
mehdiataei
requested changes
Oct 18, 2024
mehdiataei
reviewed
Oct 18, 2024
mehdiataei
requested changes
Oct 18, 2024
hsalehipour
force-pushed
the
major-refactoring
branch
from
004f9c2 to
cee77b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boundary conditions instances have common indices for instance at edges and corners, there was a race conditioning in indices boundary masker and the resultant bc_id for boundary voxels were not consistently correct.