LOOKDEVX-2128 - Allow specializing the topo neutral graph generator #3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JGamache-autodesk
commented
Dec 7, 2023
JGamache-autodesk
commented
- Also exports the color management preferences cache.
- Also exports the color management preferences cache.
JGamache-autodesk
requested review from
feldstj,
seando-adsk and
stefanminning-autodesk
| @@ -47,7 +47,7 @@ class MAYAUSD_CORE_PUBLIC TopoNeutralGraph | |||
| // Get the watch list gathered while traversing | |||
| const WatchList& getWatchList() const; | |||
|
|
|||
| private: | |||
| protected: | |||
There was a problem hiding this comment.
Allow downstream clients to specialize that class.
| namespace MAYAUSD_NS_DEF { | ||
|
|
||
| // We will cache the color management preferences since they are used in many loops. | ||
| ColorManagementPreferences::~ColorManagementPreferences() { RemoveSinks(); } |
There was a problem hiding this comment.
Extracted as-is from material.cpp to be used by downstream clients.
feldstj
previously approved these changes
Dec 7, 2023
| MString _renderingSpaceName; | ||
| MString _sRGBName; | ||
| std::vector<MCallbackId> _mayaColorManagementCallbackIds; | ||
| MCallbackId _mayaExitingCB { 0 }; |
There was a problem hiding this comment.
Can add this callback to the color management callback vector.
feldstj
previously approved these changes
Dec 7, 2023
JGamache-autodesk
added
the
ready-for-merge
|
@seando-adsk Ready for merge. |
stefanminning-autodesk
previously approved these changes
Dec 8, 2023
JGamache-autodesk
dismissed stale reviews from stefanminning-autodesk and feldstj
via
86d68d1
…info" This reverts commit 86d68d1.
|
@seando-adsk Still ready for merge. Last commit fully reverts previous one, which will be submitted separately. So we are still in a fully reviewed state. |
feldstj
previously approved these changes
Dec 11, 2023
Since the OgsFragment code is now shared with other clients, it must be careful around global state.
| @@ -3027,8 +2910,15 @@ MHWRender::MShaderInstance* HdVP2Material::CompiledNetwork::_CreateMaterialXShad | |||
| return shaderInstance; | |||
| } | |||
|
|
|||
| // Enable changing texcoord to geompropvalue | |||
| const auto prevUVSetName = mx::OgsXmlGenerator::getPrimaryUVSetName(); | |||
| mx::OgsXmlGenerator::setPrimaryUVSetName(_GetMaterialXData()._mainUvSetName); | |||
There was a problem hiding this comment.
Fixes issue see in demo this morning.
feldstj
approved these changes
Dec 11, 2023
seando-adsk
approved these changes
Dec 11, 2023
seando-adsk
added
build
seando-adsk
deleted the
gamaj/LOOKDEVX-2128/export_common_color_management_api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.